From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: skaurus@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15437: Segfault during insert into declarative partitioned table with a trigger creating partition
Date: Fri, 2 Nov 2018 08:58:04 +0900
Message-ID: <20181101235804.GJ1727@paquier.xyz> (raw)
In-Reply-To: <20181030041119.GA23393@paquier.xyz>
References: <15437-3fe01ee66bd1bae1@postgresql.org>
<e8079b1f-3e41-d1dc-1575-ff3cce7d76ac@lab.ntt.co.jp>
<8213.1539917571@sss.pgh.pa.us>
<ddc70376-9ddb-8637-eb69-aa7ae6f13378@lab.ntt.co.jp>
<20181029033117.GE14242@paquier.xyz>
<39fc3c42-d34e-794b-184e-4ff2481245e3@lab.ntt.co.jp>
<20181029065714.GI14242@paquier.xyz>
<751f72ac-e5d5-abef-98d8-ed1ef8c9d6cc@lab.ntt.co.jp>
<20181030041119.GA23393@paquier.xyz>
On Tue, Oct 30, 2018 at 01:11:19PM +0900, Michael Paquier wrote:
> That seems to be what we are looking for. Let's wait a couple of days
> and see if anybody else has any input to offer on the matter. I also
> would like to think about it again once.
And so I did.
s/paritioned/partitioned/ in the new comment of tablecmds.c.
The tests could be designed better. We had better not use the same
object names across multiple tests. If for a reason or another both
test suites are moved to the same series when running in parallel, this
can lead to race conditions which would be annoying to debug. Test
cases are not much portable as they rely on default partitions and this
bug happens down to v10, where we need to back-patch. It can be
changed so as we use FOR VALUES (1) or such in the DDL part of the
function.
Those are easy enough to fix and improve, and the patch looks good to
me. Any objections to commit and back-patch before the next point
release?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, Langote_Amit_f8@lab.ntt.co.jp, tgl@sss.pgh.pa.us, skaurus@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15437: Segfault during insert into declarative partitioned table with a trigger creating partition
In-Reply-To: <20181101235804.GJ1727@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox