pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: hugh@whtc.ca, daniel@manitou-mail.org, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Tue, 18 Dec 2018 15:33:04 +0900
Message-ID: <20181218063304.GN1532@paquier.xyz> (raw)
In-Reply-To: <11345.1545114237@sss.pgh.pa.us>
References: <29419.1544908811@sss.pgh.pa.us>
	<CAEepm=3gSmNWkteBxCEL-W+j1dmbcNzDin_iv+f_Om6o+1fAiA@mail.gmail.com>
	<CAAhbUMOX4QLj6c0O3GnjZYtR2dpAowss832Bq1n7oJyByeR7kQ@mail.gmail.com>
	<31564.1545078667@sss.pgh.pa.us>
	<CAAhbUMOe_VeJBxVqPe4Op2XKrT+xCcCvsUYRH4v6G71NDGG=fg@mail.gmail.com>
	<CAEepm=0qb_nx-f8cACS1=1NdmCj-3D9zXFU+RJHsFbZEztcqjg@mail.gmail.com>
	<20181218045708.GI1532@paquier.xyz>
	<8506.1545111362@sss.pgh.pa.us>
	<20181218060735.GL1532@paquier.xyz>
	<11345.1545114237@sss.pgh.pa.us>

On Tue, Dec 18, 2018 at 01:23:57AM -0500, Tom Lane wrote:
> Maybe I'm misremembering, but I thought that discussion was about the
> code files.  I am still mistrustful of non-ASCII in our code files.

Yes, that was in generate_unaccent_rules.py:
https://www.postgresql.org/message-id/25859.1535076450@sss.pgh.pa.us

> But for data and test files, we've been accepting UTF8 ever since the
> text-search-in-core stuff landed.  Heck, unaccent.rules itself is UTF8.

Okay, fine by me.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20181218063304.GN1532@paquier.xyz/2-signature.asc)
  download

view thread (59+ messages)  latest in thread

Message-ID: <20181218063304.GN1532@paquier.xyz>
Permalink:  ../20181218063304.GN1532@paquier.xyz/
Also on:    postgresql.org/message-id/20181218063304.GN1532@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
  In-Reply-To: <20181218063304.GN1532@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox