pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hugh Ranalli <hugh@whtc.ca>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: thomas.munro@enterprisedb.com, Daniel Verite <daniel@manitou-mail.org>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Thu, 3 Jan 2019 10:15:22 +0900
Message-ID: <20190103011522.GA2107@paquier.xyz> (raw)
In-Reply-To: <23324.1546457552@sss.pgh.pa.us>
References: <CAEepm=3gSmNWkteBxCEL-W+j1dmbcNzDin_iv+f_Om6o+1fAiA@mail.gmail.com>
	<CAAhbUMOX4QLj6c0O3GnjZYtR2dpAowss832Bq1n7oJyByeR7kQ@mail.gmail.com>
	<31564.1545078667@sss.pgh.pa.us>
	<CAAhbUMOe_VeJBxVqPe4Op2XKrT+xCcCvsUYRH4v6G71NDGG=fg@mail.gmail.com>
	<CAEepm=0qb_nx-f8cACS1=1NdmCj-3D9zXFU+RJHsFbZEztcqjg@mail.gmail.com>
	<CAAhbUMMzPERSe3KfKKQfR4COJCZSrss1G7KRyUraYJyvrVyOUg@mail.gmail.com>
	<CAAhbUMNyZ+PhNr_mQ=G161K0-hvbq13Tz2is9M3WK+yX9cQOCw@mail.gmail.co!m>
	<522acda7-c7fe-4b2e-f134-02c73a091be9@2ndquadrant.com>
	<CAAhbUMOG_S4DLQSDw3Jbqf8vipuvCAfxvH7T8+W2H0jFA-2K-g@mail.gmail.com>
	<23324.1546457552@sss.pgh.pa.us>

On Wed, Jan 02, 2019 at 02:32:32PM -0500, Tom Lane wrote:
> Seeing that supporting python 2 only adds a dozen lines of code,
> I vote for retaining it for now.  It'd be appropriate to drop that when
> python 3 is the overwhelmingly more-installed version, but AFAICT that
> isn't the case yet.

As a side note, if I recall correctly Python 2.7 will be EOL'd in
2020 by community, though I suspect that a couple of vendors will
still maintain compatibility for a couple of years in what they ship.
CentOS and RHEL enter in this category perhaps.  Like Peter, I would
vote for just maintaining support for Python 3 in this script, as any
modern development machines have it anyway, and not a lot of commits
involve it (I am counting 4 since 2015).
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190103011522.GA2107@paquier.xyz/2-signature.asc)
  download

view thread (59+ messages)  latest in thread

Message-ID: <20190103011522.GA2107@paquier.xyz>
Permalink:  ../20190103011522.GA2107@paquier.xyz/
Also on:    postgresql.org/message-id/20190103011522.GA2107@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, hugh@whtc.ca, peter.eisentraut@2ndquadrant.com, daniel@manitou-mail.org, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
  In-Reply-To: <20190103011522.GA2107@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox