pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: John Klann <jk7255@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
Date: Mon, 18 Feb 2019 11:55:11 +0900
Message-ID: <20190218025511.GA15532@paquier.xyz> (raw)
In-Reply-To: <CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>
References: <CAHyX5+VcEtcoOAo4QQ_20gv7kLYBDnx_YOAnEJQN9KftH0qp9Q@mail.gmail.com>
	<CAEepm=0eC5ySeOsXMqXQFeJ64mhgAqxAyuh7JpjCz7uT2Ld0jQ@mail.gmail.com>
	<CAHyX5+XqkmHwxLC5aeYOjHFAvnf8X1o3grkzGJOvc-kOGpjQ8g@mail.gmail.com>
	<CAHyX5+VO-UTE-pK2i1rWvweU2CpVtHuhXnok29Z66EpLHmiHvw@mail.gmail.com>
	<CAEepm=05ff+GRYdVE7+SdDuTVbPqW+Gmpwqir0NtAWNM70jg3g@mail.gmail.com>
	<CAHyX5+W2OXAg=qEnObA3g4zU3SkwxTztSfmgmivWnWQWcsc_tA@mail.gmail.com>
	<CAEepm=1P0WD_g=ELNmBJFhwKuCjYZOi4p4rutKj3kw7QneLB2A@mail.gmail.com>
	<CAHyX5+UxmOn-qpb+++NOr3MfZiXk6WZDKFYTEj+vPbu+3nrhXg@mail.gmail.com>
	<CAHyX5+X60D0jtf4dgyt11mH=7XvuW1UOLstY9sBLgukyf8Oo4g@mail.gmail.com>
	<CAEepm=27vTw2xyTh5kAXns8h5zOKUmzBxUL82c-KFFgyUQ0MHw@mail.gmail.com>

On Mon, Feb 18, 2019 at 02:34:15PM +1300, Thomas Munro wrote:
> You mentioned that you were on RHEL 7.5, which ships with a 3.10
> kernel.  When you eventually move to RHEL 8 (4.x) or even install an
> alternative newer kernel for 7.x, the problem will hopefully go away
> by itself.  Considering that, the lack of other complaints, and the
> availability of a workaround (--no-sync followed by "sync"), I'm not
> so sure it's worth committing this.

If we get to ignore EINVAL, then we won't know that fsync has failed
even in cases where the caller has done an incorrect thing by using a
special file, which sounds like a bad idea for the core code as much
as any plugins calling that?
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190218025511.GA15532@paquier.xyz/2-signature.asc)
  download

view thread (18+ messages)  latest in thread

Message-ID: <20190218025511.GA15532@paquier.xyz>
Permalink:  ../20190218025511.GA15532@paquier.xyz/
Also on:    postgresql.org/message-id/20190218025511.GA15532@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@enterprisedb.com, jk7255@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15636: PostgreSQL 11.1 pg_basebackup backup to a CIFS destination throws fsync error at end of backup
  In-Reply-To: <20190218025511.GA15532@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox