From: Michael Paquier <michael@paquier.xyz>
To: Ramanarayana <raam.soft@gmail.com>
Cc: Hugh Ranalli <hugh@whtc.ca>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
Date: Mon, 18 Feb 2019 12:36:48 +0900
Message-ID: <20190218033648.GE15532@paquier.xyz> (raw)
In-Reply-To: <CAKm4Xs6JrgX-fb-WpNMMJSz1kAp3HP8N7wnUKbU3ZHW7eHoG4A@mail.gmail.com>
References: <15548-cef1b3f8de190d4f@postgresql.org>
<CAEepm=2qfx8Q9PEq3H5KJ74a6RDgpsaJf0kK+PyGEBneC0Sr1g@mail.gmail.com>
<154982918542.11785.1374991294537224097.pgcf@coridan.postgresql.org>
<CAAhbUMODj1cCHjCpZ-=kxJxnVWyTsqu6ZnWe8+gCsb5SGnv=zA@mail.gmail.com>
<CAKm4Xs7CBuCW_XQtrVX6ThwSMiL0WK7Cj3nZx2Jymb9eJ=YdMQ@mail.gmail.com>
<CAAhbUMOieimkZrCjpw2vQJ-k3p_jzzNsimdi0aq7dwTvKy2isA@mail.gmail.com>
<CAKm4Xs6JrgX-fb-WpNMMJSz1kAp3HP8N7wnUKbU3ZHW7eHoG4A@mail.gmail.com>
On Sun, Feb 17, 2019 at 12:45:39PM +0530, Ramanarayana wrote:
> The patch I submitted was tested both in python 2 and 3 and it worked for
> me.The single line of code
> added in the patch runs only in python 3. I dont think it can break
> python2. Would like to see the error you got in python 2 Good to know the
> reported issue is a valid one in windows.I tested your patch as well and
> it is also working fine.
I can see that the commit fest entry associated to this thread has
been switched back from "committed" to "Needs Review" with Thomas
Munro still associated as committer. The thing is that we have
already committed all the bits discussed here, so I am switching back
the status as "committed", which reflects the state of the thread. If
you have a set of fixes for what has been pushed regarding Windows and
Python 2/3 capabilities, I would suggest to create a new entry with
yourself as the author. Spawning a new thread would be also nice so
as you attract the correct audience, this thread about initially
diacritical character support for unaccent has been used more than
enough now.
Python 2/3 support for this script is easy enough to check on Linux,
and now you are adding Windows in the mix...
Thanks,
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190218033648.GE15532@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, raam.soft@gmail.com, hugh@whtc.ca, pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters
In-Reply-To: <20190218033648.GE15532@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox