From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: cyberdemn@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
Date: Mon, 15 Apr 2019 12:39:06 +0900
Message-ID: <20190415033906.GA3526@paquier.xyz> (raw)
In-Reply-To: <20190411030712.GH2728@paquier.xyz>
References: <20190410060427.GB2728@paquier.xyz>
<20190410150121.GA26340@alvherre.pgsql>
<20190411030712.GH2728@paquier.xyz>
On Thu, Apr 11, 2019 at 12:07:12PM +0900, Michael Paquier wrote:
> What do you think about the set attached? I prefer that we use
> psql(on_error_die => 1) so as in the case of a crash or an error the
> test dies hard and fast. In consequence, I have granted
> pg_read_all_settings to the replication user to ensure that no errors
> happen, still the syscache lookup is done. We could have negative
> tests but I don't think that's worth the addition as we already have
> tests for pg_read_all_settings in src/test/regress/. If I remove the
> patched patch from walsender.c, the test fails immediately.
I have done another round of review of this patch and committed it
down to v10. When testing on Windows, I have noticed that these new
regression tests suffer the same problem with SSPI authentication as
the recent tweaks I have done for pg_rewind. So I have backpatched
the extension for PostgresNode::init done in d9f543e9 to be able to
add extra options for the authentication configuration so as the new
tests are able to work.
Thanks Alexander for the report!
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, cyberdemn@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15734: Walsender process crashing when executing SHOW ALL;
In-Reply-To: <20190415033906.GA3526@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox