From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: serpashk@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017
Date: Sat, 22 Jun 2019 11:44:33 +0900
Message-ID: <20190622024433.GA1713@paquier.xyz> (raw)
In-Reply-To: <CAC+AXB2gyrRJE+8gPwWTptaMTEH31dzJDsBSTMc3twn56zb=jQ@mail.gmail.com>
References: <15789-8fc75dea3c5a17c8@postgresql.org>
<CAC+AXB1Vw81MzWAPNmvpQhr_dDezucA1xu_JB9-asxzOk0rGYA@mail.gmail.com>
<20190528105802.GC2682@paquier.xyz>
<CAC+AXB2gUvPEg_AcCVE-DREP3nECi7bvaaOhre-sZVHj7Khjhw@mail.gmail.com>
<20190531142832.GQ2848@paquier.xyz>
<CANFyU977NVQCO_Xu_er76Eezg2D3zVNNmf_d7j5d5iq2T6FLdw@mail.gmail.com>
<20190603235132.GA1529@paquier.xyz>
<CAC+AXB3_YNqAr=u9ccuXOoKQF=kZRQFjnLgRaSFQEjNz+Po+1w@mail.gmail.com>
<20190620024941.GB2660@paquier.xyz>
<CAC+AXB2gyrRJE+8gPwWTptaMTEH31dzJDsBSTMc3twn56zb=jQ@mail.gmail.com>
On Fri, Jun 21, 2019 at 12:23:21PM +0200, Juan José Santamaría Flecha wrote:
> Since the third parameter is only currently used with OpenSSL
> libraries, I thought it would be ok to touch it in this patch. The
> reasson behind doing so was to keep the logic for the new fancy
> library naming tidy. Documenting better is not a thing I can argue
> against, xlib stands for expanded library name as used in
> GetAdditionalLinkerDependencies and maybe a comment like this can make
> things clearer:
>
> # The parameter $slib is for sufixed run-time library.
> # When available it will be added, if not it silently defaults to $lib.
> sub AddLibrary
That's a sensible argument. Perhaps your way of doing is much better
at the end. I still found the patch hard to follow in the changes it
did though, so documenting things for the changes you are doing would
help anybody looking at this code in the future.
> No problem with that. Even more so, it can return 4 values: the 3
> digits and the letter. For example, 1.1.1b would be (1, 1, 1, b).
There are two reasons why we need to know the version of OpenSSL
dynamically:
1) Enforce the correct compilation flags in pg_config.h
2) Select the correct library paths.
OpenSSL keeps API compatibility in their stable branches, so 1. would
not be an issue. I suspect as well that the installers we use for
Postgres compilation are not going to change their layer in a minor
version update. So having only 3 digits is enough. 2 likely not. I
would just keep it at three for now.
Could you send an updated patch? I would like to look at this stuff
rather sooner than later as OpenSSL 1.0.2 goes EOL in a couple of
months, so there is going to be demand for it.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, juanjo.santamaria@gmail.com, sandeep.thakkar@enterprisedb.com, serpashk@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017
In-Reply-To: <20190622024433.GA1713@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox