pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: serpashk@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017
Date: Wed, 26 Jun 2019 10:22:56 +0900
Message-ID: <20190626012256.GA1714@paquier.xyz> (raw)
In-Reply-To: <20190625135243.GA29893@alvherre.pgsql>
References: <20190625080811.GF5569@paquier.xyz>
	<20190625135243.GA29893@alvherre.pgsql>

On Tue, Jun 25, 2019 at 09:52:43AM -0400, Alvaro Herrera wrote:
> In sub GenerateFiles, I would move the stanza for ->{openssl} next to
> the one for ->{gss} and keep the simpler lines all together (your patch
> leaves ->{nls} as a separate item, which is aesthetically unpleasing).

Right, thanks.  This makes the flow cleaner.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (18+ messages)  latest in thread

Message-ID: <20190626012256.GA1714@paquier.xyz>
Permalink:  ../20190626012256.GA1714@paquier.xyz/
Also on:    postgresql.org/message-id/20190626012256.GA1714@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, juanjo.santamaria@gmail.com, sandeep.thakkar@enterprisedb.com, serpashk@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15789: libpq compilation with OpenSSL 1.1.1b fails on Windows with Visual Studio 2017
  In-Reply-To: <20190626012256.GA1714@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox