From: Michael Paquier <michael@paquier.xyz>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: gaolin01@beyondsoft.com, pgsql-bugs@lists.postgresql.org, Haribabu Kommi <kommi.haribabu@gmail.com>
Subject: Re: BUG #15889: PostgreSQL failed to build due to error MSB8020 with MSVC on windows
Date: Thu, 4 Jul 2019 17:32:14 +0900
Message-ID: <20190704083214.GR3084@paquier.xyz> (raw)
In-Reply-To: <CAC+AXB1FbHdKwh+3JAmCOyRqecnRWCo3Tz1GzQLK07FT74OO3g@mail.gmail.com>
References: <15889-1ee90dbc3b860518@postgresql.org>
<20190703113551.GH3084@paquier.xyz>
<CAC+AXB1FbHdKwh+3JAmCOyRqecnRWCo3Tz1GzQLK07FT74OO3g@mail.gmail.com>
On Thu, Jul 04, 2019 at 10:18:44AM +0200, Juan José Santamaría Flecha wrote:
> In that building environment, if you edit
> ".\src\tools\msvc\buildenv.pl" to add the following line:
>
> $ENV{MSBFLAGS}="/p:PlatformToolset=v141";
>
> Does it work as workaround for you?
>
> Anyhow, could you please share what nmake version are you using?
As a side thought, we could also move away from nmake when it comes to
find out the version of Visual Studio used if Microsoft is lazy with
nmake's version number. For example we could consider using
"MSBuild.exe -version" and parse its output. This reports 16.1.XX.YY
for me with VS 2019, and 14.0.XX.YY with VS 2015.
Not sure how portable that it though past those versions. Still, on
HEAD and v12, we only support VS 2013 and newer versions, so we could
integrate with it easily.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, juanjo.santamaria@gmail.com, kommi.haribabu@gmail.com
Subject: Re: BUG #15889: PostgreSQL failed to build due to error MSB8020 with MSVC on windows
In-Reply-To: <20190704083214.GR3084@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox