From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15899: Valgrind detects errors on create gist index
Date: Wed, 10 Jul 2019 16:02:19 +0900
Message-ID: <20190710070219.GF1031@paquier.xyz> (raw)
In-Reply-To: <20190709044341.GA23827@paquier.xyz>
References: <15899-0d24fb273b3dd90c@postgresql.org>
<38f18230-e766-3a87-e3ad-fef6562c0c23@gmail.com>
<20190709044341.GA23827@paquier.xyz>
On Tue, Jul 09, 2019 at 01:43:41PM +0900, Michael Paquier wrote:
> Regarding the zero-allocation, we have gistLoadNodeBuffer() loading
> directly the block's contents from a temporary file after allocating a
> page, but gistPushItupToNodeBuffer() justifies that as a cheap
> insurance. So that's good for me. Do others have objections or extra
> thoughts? This comes from 1d27dcf, so this should go all the way down.
Tested and committed down to 9.4.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15899: Valgrind detects errors on create gist index
In-Reply-To: <20190710070219.GF1031@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox