pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jorge Gustavo Rocha <jgr@geomaster.pt>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2
Date: Fri, 26 Jul 2019 13:58:08 +0900
Message-ID: <20190726045808.GF7677@paquier.xyz> (raw)
In-Reply-To: <29487.1564071212@sss.pgh.pa.us>
References: <23215.1560977098@sss.pgh.pa.us>
	<20190620031218.GC2660@paquier.xyz>
	<20190620070319.GH2660@paquier.xyz>
	<0a9fcd30-5ae2-7e5f-ac1d-60d14a2ebb63@geomaster.pt>
	<20190621004233.GA1626@paquier.xyz>
	<3383.1561078113@sss.pgh.pa.us>
	<25605.1561652435@sss.pgh.pa.us>
	<20190628031056.GA1797@paquier.xyz>
	<5805.1561750411@sss.pgh.pa.us>
	<29487.1564071212@sss.pgh.pa.us>

On Thu, Jul 25, 2019 at 12:13:32PM -0400, Tom Lane wrote:
> Hearing nothing further on this, I went ahead with the patch as I had it
> on HEAD, and a tweaked version of your patch on the back branches.

Thanks Tom for taking care of that stuff.  Coming late at the party, I
have one comment post-commit.  Perhaps we could have a wrapper in
charge of doing this work in with something adding properly \0 at the
end of those strings for CR and LF and returning the new length after
adjustment, like pg_strip_clrf in common/string.c?  There are nine
places changed on HEAD.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190726045808.GF7677@paquier.xyz/2-signature.asc)
  download

view thread (23+ messages)

Message-ID: <20190726045808.GF7677@paquier.xyz>
Permalink:  ../20190726045808.GF7677@paquier.xyz/
Also on:    postgresql.org/message-id/20190726045808.GF7677@paquier.xyz

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, jgr@geomaster.pt, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2
  In-Reply-To: <20190726045808.GF7677@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox