From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: rafaelthca@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
Date: Thu, 1 Aug 2019 09:42:11 +0900
Message-ID: <20190801004211.GD29334@paquier.xyz> (raw)
In-Reply-To: <B8D6D6DC-484B-4D14-9CAD-F08B486E0B8B@yesql.se>
References: <15932-78f48f9ef166778c@postgresql.org>
<20190730022420.GC1742@paquier.xyz>
<20190731071503.GA29334@paquier.xyz>
<97C01A5D-D814-413E-A8C8-146B17FBB63B@yesql.se>
<20190731073401.GB29334@paquier.xyz>
<B8D6D6DC-484B-4D14-9CAD-F08B486E0B8B@yesql.se>
On Wed, Jul 31, 2019 at 09:54:17AM +0200, Daniel Gustafsson wrote:
> Hmm, ok, IMO my comment applies to those as well, but it may very well be me
> just reading it wrong. Either way, +1 for pushing your patch.
I am not saying that this cannot be improved either, still I am not
sure how it could be reworded. And if we do that, it should be
applied to all places where we use it. I have fixed the issue and
back-patched down to 9.4. Perhaps that was not worth caring about,
but the versions for the back-branches were not really an issue.
Thanks for the report, Rafael. And thanks for the review, Daniel.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190801004211.GD29334@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, daniel@yesql.se, rafaelthca@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15932: Module passwordcheck doesn't reference previous hooks
In-Reply-To: <20190801004211.GD29334@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox