From: Michael Paquier <michael@paquier.xyz>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
Date: Tue, 6 Aug 2019 15:21:11 +0900
Message-ID: <20190806062111.GG32256@paquier.xyz> (raw)
In-Reply-To: <97ac4fe2-65d9-6a7b-76e0-5ad3b06cd9dc@gmail.com>
References: <15910-2eba5106b9aa0c61@postgresql.org>
<0aaf1cb9-0f85-e786-fb32-b3d68b80d027@gmail.com>
<97ac4fe2-65d9-6a7b-76e0-5ad3b06cd9dc@gmail.com>
On Mon, Aug 05, 2019 at 08:55:55AM +0300, Alexander Lakhin wrote:
> In case this bug is worth fixing, please look at the improved patch with
> the corresponding regression test.
In this case, DecodeSpecial() decodes the abbrevation passed down as
UNITS, which is right on its own. Still, afterwards the code fails to
correctly set a date from the string present. In short, your
suggestion of fix looks good to me and that's more consistent with the
full timezone spec case. The test case you added in this patch
triggers the error in the code path where the timezone is not
specified. Could you add an extra test case for the timezone
abbreviation?
Note that the next set of minor versions is very close by (we are in a
cease-fire period for commits on back-branches), so this won't be
fixed in the upcoming releases.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15910: Valgrind-detected error in DecodeTimeOnly
In-Reply-To: <20190806062111.GG32256@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox