From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: jungleboogie0@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
Date: Tue, 20 Aug 2019 22:40:05 -0400
Message-ID: <20190821024005.GA16883@alvherre.pgsql> (raw)
In-Reply-To: <20190821015854.GD1684@paquier.xyz>
On 2019-Aug-21, Michael Paquier wrote:
> + if (PQsocket(conn) >= FD_SETSIZE)
> + {
> + fprintf(stderr, "too many jobs for this platform's select()\n");
> + exit(1);
> + }
BTW why fprintf? Since you can get into this by careless use of -j,
ISTM that this should be a translatable string. I'd consider
pg_log_fatal(). Maybe something like "Argument of -j too large for this
platform -- try %d", numslots - i.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, dilipbalaut@gmail.com, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'
In-Reply-To: <20190821024005.GA16883@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox