From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org, Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #16039: PANIC when activating replication slots in Postgres 12.0 64bit under Windows
Date: Tue, 8 Oct 2019 09:32:40 +0900
Message-ID: <20191008003240.GA1613@paquier.xyz> (raw)
In-Reply-To: <20191006045548.GA14532@paquier.xyz>
References: <16039-196fc97cc05e141c@postgresql.org>
<20191004200605.yqcmn75otebwcvyj@alap3.anarazel.de>
<20191006045548.GA14532@paquier.xyz>
On Sun, Oct 06, 2019 at 01:55:48PM +0900, Michael Paquier wrote:
> It would have been nice to add some sanity checks based on fcntl() but
> directory handling in pg_fsync() makes that annoying. Anyway, I have
> checked the code with a little trick, and I have spotted a second bug:
> CheckPointLogicalRewriteHeap() fsyncs a logical rewrite mapping file
> with RDONLY. This is incorrect since b89e151.
Andres, others, any thoughts about this issue? Are there any
objections if I just fix it?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, michael.paquier@gmail.com
Subject: Re: BUG #16039: PANIC when activating replication slots in Postgres 12.0 64bit under Windows
In-Reply-To: <20191008003240.GA1613@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox