pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrey Salnikov <andrey.salnikov@dataegret.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16125: Crash of PostgreSQL's wal sender during logical replication
Date: Wed, 27 Nov 2019 16:35:06 +0100
Message-ID: <20191127153506.tuqlckfj426rkrlb@development> (raw)
In-Reply-To: <20191127145700.GF4161@alvherre.pgsql>
References: <20191119232849.qhtuhq4udrqrz4he@alap3.anarazel.de>
	<20191127142204.GA13686@alvherre.pgsql>
	<20191127145700.GF4161@alvherre.pgsql>

On Wed, Nov 27, 2019 at 11:57:00AM -0300, Alvaro Herrera wrote:
>On 2019-Nov-27, Alvaro Herrera wrote:
>
>> I think pg_waldump should print out the speculativeness of an insertion.
>
>Ah, in pg12 we do print the "flags" for the insertion.  But earlier
>releases don't.  IMO we should have backpatched that change, as I said
>in https://postgr.es/m/20180423160216.m2yjhx67grofg7h5@alvherre.pgsql
>but I was outvoted.
>

Hmmmm, yeah. I still think the decision not to backpatch was reasonable,
although it seems it might have been useful in this particular case.

But hey, it should not be that difficult to build a custom pg_waldump
version with that patch applied, and decode the WAL segment. It can even
be done on a completely separate system, it's just a single binary.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (17+ messages)  latest in thread

Message-ID: <20191127153506.tuqlckfj426rkrlb@development>
Permalink:  ../20191127153506.tuqlckfj426rkrlb@development/
Also on:    postgresql.org/message-id/20191127153506.tuqlckfj426rkrlb@development

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, andres@anarazel.de, andrey.salnikov@dataegret.com
  Subject: Re: BUG #16125: Crash of PostgreSQL's wal sender during logical replication
  In-Reply-To: <20191127153506.tuqlckfj426rkrlb@development>
  References: <20191119232849.qhtuhq4udrqrz4he@alap3.anarazel.de> <20191127142204.GA13686@alvherre.pgsql> <20191127145700.GF4161@alvherre.pgsql> <20191127153506.tuqlckfj426rkrlb@development>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox