From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Manuel Rigger <rigger.manuel@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: REINDEX CONCURRENTLY unexpectedly fails
Date: Fri, 13 Dec 2019 11:47:33 +0900
Message-ID: <20191213024733.GC1942@paquier.xyz> (raw)
In-Reply-To: <20191212201108.GA2944@alvherre.pgsql>
References: <20191120035408.GA4243@paquier.xyz>
<20191212201108.GA2944@alvherre.pgsql>
On Thu, Dec 12, 2019 at 05:11:08PM -0300, Alvaro Herrera wrote:
> I liked Andres' original naming suggestion better FWIW. With this, one
> wonders "concurrently what?"
I did not like the "creation" part from the original suggestion :)
IndexCreationSupportsConcurrent() called from a place where an index
is dropped does not sound very consistent.
> Some suggestions,
> "RelationSupportsConcurrentIndexing" or
> "IndexSupportsConcurrently". Maybe replace the "ing" in the first or
> "ly" in the second with "DDL" or "Ops". (Also, if it's just about
> indexes and appears in index.h, why did you use the prefix "Relation"?)
RelationSupportsConcurrentIndexing sounds like a good compromise to
me. The reasoning behind using relation is that this check can be
used for an index or its parent relation.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, rigger.manuel@gmail.com
Subject: Re: REINDEX CONCURRENTLY unexpectedly fails
In-Reply-To: <20191213024733.GC1942@paquier.xyz>
References: <20191120035408.GA4243@paquier.xyz> <20191212201108.GA2944@alvherre.pgsql> <20191213024733.GC1942@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox