pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jobin Augustine <jobinau@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: libpq parameter parsing problem
Date: Tue, 14 Jan 2020 17:55:05 +0900
Message-ID: <20200114085505.GA83028@paquier.xyz> (raw)
In-Reply-To: <CANaTPsr=_2+Ajb-ENdT9QZyk3fjRSrgM+iuZO7vtxe0FU36NGQ@mail.gmail.com>
References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com>
	<CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com>
	<CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com>
	<22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi>
	<20200109043809.GK2251@paquier.xyz>
	<CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com>
	<20200114060317.GF1515@paquier.xyz>
	<CANaTPsr=_2+Ajb-ENdT9QZyk3fjRSrgM+iuZO7vtxe0FU36NGQ@mail.gmail.com>

On Tue, Jan 14, 2020 at 12:01:43PM +0530, Jobin Augustine wrote:
> Yes, agree, readability is better with that modification.
> Attaching a modified patch.

(Please always top-post, this is the style of the PostgreSQL community
mailing lists).  The new patch looks good to me, let's see if others
have extra thoughts to share.  If not, I'll try to commit it.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (22+ messages)  latest in thread

Message-ID: <20200114085505.GA83028@paquier.xyz>
Permalink:  ../20200114085505.GA83028@paquier.xyz/
Also on:    postgresql.org/message-id/20200114085505.GA83028@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, jobinau@gmail.com, hlinnaka@iki.fi, oleksandr.shulgin@zalando.de
  Subject: Re: libpq parameter parsing problem
  In-Reply-To: <20200114085505.GA83028@paquier.xyz>
  References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com> <CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com> <CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com> <22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi> <20200109043809.GK2251@paquier.xyz> <CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com> <20200114060317.GF1515@paquier.xyz> <CANaTPsr=_2+Ajb-ENdT9QZyk3fjRSrgM+iuZO7vtxe0FU36NGQ@mail.gmail.com> <20200114085505.GA83028@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox