pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Jobin Augustine <jobinau@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: libpq parameter parsing problem
Date: Wed, 15 Jan 2020 11:40:30 +0900
Message-ID: <20200115024030.GC2243@paquier.xyz> (raw)
In-Reply-To: <CAKFQuwaDd-azJDV_BQJj8R8Xxj6k35tehqwD0n7huTjgj+1Aqw@mail.gmail.com>
References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com>
	<CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com>
	<CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com>
	<22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi>
	<20200109043809.GK2251@paquier.xyz>
	<CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com>
	<20200114060317.GF1515@paquier.xyz>
	<CANaTPsr=_2+Ajb-ENdT9QZyk3fjRSrgM+iuZO7vtxe0FU36NGQ@mail.gmail.com>
	<CAKFQuwaDd-azJDV_BQJj8R8Xxj6k35tehqwD0n7huTjgj+1Aqw@mail.gmail.com>

On Tue, Jan 14, 2020 at 06:52:07PM -0700, David G. Johnston wrote:
> I would probably choose to move the example for the options parameters to
> the "Parameter Key Words" options section:

I think that this would be inconsistent with the rest, as that's a URI
and all the other examples are there.  I agree with the feeling of
Alvaro upthread that we could do a better effort with the handling of
the examples in this section, but it is quite unclear to me if that
would actually bring more clarity to the whole, and that's not really
the job of this patch.

> Also, regardless of where it is placed having both the username and
> database both be named "postgres" in an example just adds unnecessary
> mental effort to understanding the example.  One that none of the existing
> examples do.  Name your user "user" and database "mydb" unless, as with the
> desire to include a space, there is a meaningful reason not to.

Good point.  Using "mydb" or "user" instead of "postgres" in the new
example would be less confusing.  Another question, would be it better
to use "5433" instead of "5432" for the port number.  That's a nit,
but as we are on that stuff let's be right..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (22+ messages)  latest in thread

Message-ID: <20200115024030.GC2243@paquier.xyz>
Permalink:  ../20200115024030.GC2243@paquier.xyz/
Also on:    postgresql.org/message-id/20200115024030.GC2243@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, david.g.johnston@gmail.com, jobinau@gmail.com, hlinnaka@iki.fi, oleksandr.shulgin@zalando.de
  Subject: Re: libpq parameter parsing problem
  In-Reply-To: <20200115024030.GC2243@paquier.xyz>
  References: <CANaTPsrYgSgE2fuj3=4x=Jmx1c+NgkEDzftNknZbrMuqL+aBhQ@mail.gmail.com> <CACACo5Qf4xBbs=8s4sYxZiQEYzfKM3JY3uCDrtZYu3CpOcP5xA@mail.gmail.com> <CANaTPsrgsrVK2nb6bPym-fZcQvL7aJErMCXek7LBp-QFDQt-RQ@mail.gmail.com> <22b4a79a-5d60-cec0-474e-4a68c8be2b7a@iki.fi> <20200109043809.GK2251@paquier.xyz> <CANaTPsqq17XvXDsrm4J6GXZqnNw=0=Y+txMRyBBTJn4sGJw9ig@mail.gmail.com> <20200114060317.GF1515@paquier.xyz> <CANaTPsr=_2+Ajb-ENdT9QZyk3fjRSrgM+iuZO7vtxe0FU36NGQ@mail.gmail.com> <CAKFQuwaDd-azJDV_BQJj8R8Xxj6k35tehqwD0n7huTjgj+1Aqw@mail.gmail.com> <20200115024030.GC2243@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox