pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Reorderbuffer crash during recovery
Date: Fri, 17 Jan 2020 18:12:16 -0300
Message-ID: <20200117211216.GA7044@alvherre.pgsql> (raw)
In-Reply-To: <CALDaNm3XSXFed++sRSCu27XOQcEWsXcx1+2a3LGs1V+a3WXDpQ@mail.gmail.com>

On 2020-Jan-17, vignesh C wrote:

> Thanks Dilip for reviewing.
> I have fixed the comments you have suggested.

I ended up rewording that comment completely; I thought the original was
not explaining things well enough.

I also changed the comment for final_lsn in reorderbuffer.h: not only I
remove the line that I added in df9f682c7bf8 (the previous bugfix), but
I also remove the line that says "error during decoding", which came in
with the very first logical decoding commit (b89e151054a); I couldn't
find any evidence that final_lsn is being set on errors of any kind
(other than transaction abort, which doesn't seem an "error" in that
sense.)

Please give these comments a read; maybe I have misunderstood something
and my comment is wrong.

Pushed now to all branches.  Thanks, Vignesh, Amit and Dilip.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (22+ messages)  latest in thread

Message-ID: <20200117211216.GA7044@alvherre.pgsql>
Permalink:  ../20200117211216.GA7044@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200117211216.GA7044@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@2ndquadrant.com, vignesh21@gmail.com, dilipbalaut@gmail.com, amit.kapila16@gmail.com, andres@anarazel.de, tomas.vondra@2ndquadrant.com, pgsql-hackers@postgresql.org
  Subject: Re: Reorderbuffer crash during recovery
  In-Reply-To: <20200117211216.GA7044@alvherre.pgsql>
  References: <CALDaNm3XSXFed++sRSCu27XOQcEWsXcx1+2a3LGs1V+a3WXDpQ@mail.gmail.com> <20200117211216.GA7044@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox