pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Vik Fearing <vik@postgresfriends.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16242: convert_tuple_* not handling missing values correctly
Date: Thu, 6 Feb 2020 14:48:46 +0900
Message-ID: <20200206054846.GI23913@paquier.xyz> (raw)
In-Reply-To: <87zhdwn8le.fsf@news-spur.riddles.org.uk>
References: <16242-d1c9fca28445966b@postgresql.org>
	<31edb400-f065-73c4-7b1f-2953ad3413e6@postgresfriends.org>
	<20200205021933.c4wtkpcx2li3um2k@alap3.anarazel.de>
	<3c396c9e-960f-9c03-63b7-d58e0e044fba@postgresfriends.org>
	<20200205022634.77y7fg7vyhn2svh7@alap3.anarazel.de>
	<5e0747c0-68af-c937-b8f7-c11b12126d7a@postgresfriends.org>
	<87zhdwn8le.fsf@news-spur.riddles.org.uk>

On Wed, Feb 05, 2020 at 07:22:20PM +0000, Andrew Gierth wrote:
> I'll commit this (with fixed comments) unless anyone can immediately
> think of any reason not to...

The patch you have written looks right to me on HEAD and the
back-branches.  Now, you have added only a test that stresses
atthasmissing in convert_tuples_by_name_map_if_req(), but you are not
covering the paths from convert_tuples_by_position().  Shouldn't we
have a second test for that part as well?
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20200206054846.GI23913@paquier.xyz/2-signature.asc)
  download

view thread (9+ messages)

Message-ID: <20200206054846.GI23913@paquier.xyz>
Permalink:  ../20200206054846.GI23913@paquier.xyz/
Also on:    postgresql.org/message-id/20200206054846.GI23913@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, andrew@tao11.riddles.org.uk, vik@postgresfriends.org, andres@anarazel.de, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16242: convert_tuple_* not handling missing values correctly
  In-Reply-To: <20200206054846.GI23913@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox