pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
Date: Sat, 29 Feb 2020 08:21:38 +0900
Message-ID: <20200228232138.GI2688@paquier.xyz> (raw)
In-Reply-To: <4172.1582915529@sss.pgh.pa.us>
References: <20200108004409.GA3413@paquier.xyz>
	<5602.1578444917@sss.pgh.pa.us>
	<20200108015601.GB3413@paquier.xyz>
	<20200109040612.GG2251@paquier.xyz>
	<CAKYtNArmm0f4zYHebpQ9kf7LOJeiuexKSnnmhiOiLQc3_F39ug@mail.gmail.com>
	<20200110080125.GA250447@paquier.xyz>
	<20200110110748.GD250447@paquier.xyz>
	<20200116040618.GF3117@paquier.xyz>
	<18998.1582910402@sss.pgh.pa.us>
	<4172.1582915529@sss.pgh.pa.us>

On Fri, Feb 28, 2020 at 01:45:29PM -0500, Tom Lane wrote:
> After poking around, I see there aren't any other callers.  But I think
> that the cause of this bug is clearly failure to think carefully about
> the different cases that isTempNamespaceInUse is recognizing, so that
> the right way to fix it is more like the attached.

Good idea, thanks.  Your suggestion looks good to me.

> In the back branches, we could leave isTempNamespaceInUse() in place
> but unused, just in case somebody is calling it.  I kind of doubt that
> anyone is, given the small usage in core, but maybe.

I doubt that there are any external callers, but I'd rather leave the
past API in place on back-branches.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (37+ messages)  latest in thread

Message-ID: <20200228232138.GI2688@paquier.xyz>
Permalink:  ../20200228232138.GI2688@paquier.xyz/
Also on:    postgresql.org/message-id/20200228232138.GI2688@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, mahi6run@gmail.com, robertmhaas@gmail.com, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Assert failure due to "drop schema pg_temp_3 cascade" for temporary tables and \d+ is not showing any info after drooping temp table schema
  In-Reply-To: <20200228232138.GI2688@paquier.xyz>
  References: <20200108004409.GA3413@paquier.xyz> <5602.1578444917@sss.pgh.pa.us> <20200108015601.GB3413@paquier.xyz> <20200109040612.GG2251@paquier.xyz> <CAKYtNArmm0f4zYHebpQ9kf7LOJeiuexKSnnmhiOiLQc3_F39ug@mail.gmail.com> <20200110080125.GA250447@paquier.xyz> <20200110110748.GD250447@paquier.xyz> <20200116040618.GF3117@paquier.xyz> <18998.1582910402@sss.pgh.pa.us> <4172.1582915529@sss.pgh.pa.us> <20200228232138.GI2688@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox