pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: cameron.ezell@clearcapital.com, pgsql-bugs@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns
Date: Sat, 18 Apr 2020 18:28:56 +0900
Message-ID: <20200418092856.GE350229@paquier.xyz> (raw)
In-Reply-To: <CAApHDvpuQBiMCJsyfuqWWLCa2++QKkqttxJuh8F+98xVzNv14Q@mail.gmail.com>
References: <16369-5845a6f1bef59884@postgresql.org>
	<CAApHDvr7xeMcfGRWQ0rxtagw7CKbjEcjPKfKQAU4KdEcZm6XkQ@mail.gmail.com>
	<1047.1586994741@sss.pgh.pa.us>
	<CAApHDvqFZZOwCi35xi02G=19df7idzminAhibrHEAz4McEnX=w@mail.gmail.com>
	<20200416053036.GA81957@paquier.xyz>
	<CAApHDvpuQBiMCJsyfuqWWLCa2++QKkqttxJuh8F+98xVzNv14Q@mail.gmail.com>

On Sat, Apr 18, 2020 at 02:13:17PM +1200, David Rowley wrote:
> On Thu, 16 Apr 2020 at 17:30, Michael Paquier <michael@paquier.xyz> wrote:
> > Shouldn't you have more regression test cases here?  I guess one for
> > the non-NULL case, and one for the NULL case?
> 
> Yeah. I've just pushed a fix that included a fairly simple regression test.

Thanks for the commit, David!  I was wondering if it would have been
better to add a "\pset null", but that's a nit and the result looks
fine anyway.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (10+ messages)

Message-ID: <20200418092856.GE350229@paquier.xyz>
Permalink:  ../20200418092856.GE350229@paquier.xyz/
Also on:    postgresql.org/message-id/20200418092856.GE350229@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
  Subject: Re: BUG #16369: Segmentation Faults and Data Corruption with Generated Columns
  In-Reply-To: <20200418092856.GE350229@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox