From: Bruce Momjian <bruce@momjian.us>
To: tureba@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16380: documentation: host[no]gssenc vs. address/IP-address/IP-mask fields
Date: Tue, 21 Apr 2020 14:27:36 -0400
Message-ID: <20200421182736.GG19613@momjian.us> (raw)
In-Reply-To: <16380-45bf493d620bc29c@postgresql.org>
References: <16380-45bf493d620bc29c@postgresql.org>
On Sun, Apr 19, 2020 at 06:29:31PM +0000, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 16380
> Logged by: Arthur Nascimento
> Email address: tureba@gmail.com
> PostgreSQL version: 12.2
> Operating system: Documentation
> Description:
>
> Hi,
>
> I see a couple of inconsistencies in the documentation of the pg_hba.conf
> file in v12+:
> https://www.postgresql.org/docs/12/auth-pg-hba-conf.html (and /current/)
>
> 1. Near the top, there's a line saying "A record can have one of the seven
> formats", then the followup list shows 9 formats. The ones on host[no]gssenc
> were added to the IP-address/IP-mask section, but not to the address
> section. I believe the intention was to have 11 lines there, with a
> corresponding count at the top.
>
> 2. In the address and IP-address/IP-mask descriptions, there's "This field
> only applies to host, hostssl, and hostnossl records." and "These fields
> only apply to host, hostssl, and hostnossl records.". But those lists should
> probably be updated as well to add host[no]gssenc (or to negate the logic,
> saying they are not applied to local connections).
I agree with your suggestions. I also noticed that pg_hba.conf is
missing gssapi entries too, so I added them to the attached patch. too.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
Attachments:hba.diff (text/x-diff, 2.6K) downloaddiff --git a/doc/src/sgml/client-auth.sgml b/doc/src/sgml/client-auth.sgmlindex 5f1eec78fb..d086d32c49 100644--- a/doc/src/sgml/client-auth.sgml+++ b/doc/src/sgml/client-auth.sgml@@ -99,7 +99,7 @@
</para>
<para>
- A record can have one of the seven formats+ A record can have one of the nine formats
<synopsis>
local <replaceable>database</replaceable> <replaceable>user</replaceable> <replaceable>auth-method</replaceable> <optional><replaceable>auth-options</replaceable></optional>
host <replaceable>database</replaceable> <replaceable>user</replaceable> <replaceable>address</replaceable> <replaceable>auth-method</replaceable> <optional><replaceable>auth-options</replaceable></optional>
@@ -409,8 +409,7 @@ hostnogssenc <replaceable>database</replaceable> <replaceable>user</replaceable
</para>
<para>
- These fields only apply to <literal>host</literal>,- <literal>hostssl</literal>, and <literal>hostnossl</literal> records.+ These fields do not apply to <literal>local</literal> records.
</para>
</listitem>
</varlistentry>
diff --git a/src/backend/libpq/pg_hba.conf.sample b/src/backend/libpq/pg_hba.conf.sampleindex c853e36232..2d76992886 100644--- a/src/backend/libpq/pg_hba.conf.sample+++ b/src/backend/libpq/pg_hba.conf.sample@@ -9,17 +9,21 @@
# are authenticated, which PostgreSQL user names they can use, which
# databases they can access. Records take one of these forms:
#
-# local DATABASE USER METHOD [OPTIONS]-# host DATABASE USER ADDRESS METHOD [OPTIONS]-# hostssl DATABASE USER ADDRESS METHOD [OPTIONS]-# hostnossl DATABASE USER ADDRESS METHOD [OPTIONS]+# local DATABASE USER METHOD [OPTIONS]+# host DATABASE USER ADDRESS METHOD [OPTIONS]+# hostssl DATABASE USER ADDRESS METHOD [OPTIONS]+# hostnossl DATABASE USER ADDRESS METHOD [OPTIONS]+# hostgssenc DATABASE USER ADDRESS METHOD [OPTIONS]+# hostnogssenc DATABASE USER ADDRESS METHOD [OPTIONS]
#
# (The uppercase items must be replaced by actual values.)
#
# The first field is the connection type: "local" is a Unix-domain
# socket, "host" is either a plain or SSL-encrypted TCP/IP socket,
# "hostssl" is an SSL-encrypted TCP/IP socket, and "hostnossl" is a
-# plain TCP/IP socket.+# non-SSL TCP/IP socket. Similarly, "hostgssenc" uses a +# GSSAPI-encrypted TCP/IP socket, while "hostnogssenc" uses a+# non-GSSAPI socket.
#
# DATABASE can be "all", "sameuser", "samerole", "replication", a
# database name, or a comma-separated list thereof. The "all"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tureba@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16380: documentation: host[no]gssenc vs. address/IP-address/IP-mask fields
In-Reply-To: <20200421182736.GG19613@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox