From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nagaraj Raj <nagaraj.sf@yahoo.com>
Cc: Pg Bugs <pgsql-bugs@postgresql.org>
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition
Date: Tue, 29 Sep 2020 20:22:25 -0300
Message-ID: <20200929232225.GA16296@alvherre.pgsql> (raw)
In-Reply-To: <CAApHDvpE5omXqenT5wFLHigbJFjixqUC-DkcTw6aCFoMLmU2jw@mail.gmail.com>
On 2020-Sep-30, David Rowley wrote:
> I didn't go with the same wording. The reason was that I didn't feel
> the word "constraint" had to be mentioned twice.
>
> I won't object if you or Alvaro want to keep Alvaro's suggestion though.
*Shrug* this seems good enough. A purist could complain that it is
redundant, but in practice it's not important.
Here's the proposed error message fix, using the wording that saves
$1.99. I agree that trying to cram the constraint type in the primary
message is uglier.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-Reword-error-message.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@2ndquadrant.com, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, nagaraj.sf@yahoo.com
Subject: Re: ERROR: insufficient columns in the PRIMARY KEY constraint definition
In-Reply-To: <20200929232225.GA16296@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox