From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
Date: Wed, 30 Sep 2020 14:42:16 -0400
Message-ID: <20200930184216.GE26841@momjian.us> (raw)
In-Reply-To: <888835.1601489514@sss.pgh.pa.us>
References: <CAKFQuwaXESne_VYt8bE8L5gGGqEM0TCGL+JNL1a8NJ2_uc8VfQ@mail.gmail.com>
<CAKFQuwajC7+s-nHRujP+w5GsUTcp8usazdPas59Kz3kCTq+e3w@mail.gmail.com>
<0123b852ae3fe53eca11b9451d035411b06dafd5.camel@cybertec.at>
<CAKFQuwb_3yNTTE6cG_YtXFtV=CkQf0uMSMB0oxC1YNrF94pfuA@mail.gmail.com>
<20200904012149.GA13932@momjian.us>
<CAKFQuwZV0UxbyYTxuJhf1j1X=3HG5QA6qtEp+C+=LzOFtNEt3A@mail.gmail.com>
<20200904201224.GD6891@momjian.us>
<663099.1601400389@sss.pgh.pa.us>
<20200930175642.GC26841@momjian.us>
<888835.1601489514@sss.pgh.pa.us>
On Wed, Sep 30, 2020 at 02:11:54PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Sep 29, 2020 at 01:26:29PM -0400, Tom Lane wrote:
> >> Bruce Momjian <bruce@momjian.us> writes:
> >>> On Fri, Sep 4, 2020 at 12:45:36PM -0700, David G. Johnston wrote:
> >>>> Because we already have the to_date/make_date inconsistency, and the -1
> >>>> to -2 BC mapping is confusing, and doesn't match Oracle, I think the
> >>>> clean solution is to change PG 14 to treat -1 as 1 BC, and document the
> >>>> incompatibility in the release notes.
>
> >>> I agree that someone else should write another patch to fix the behavior for
> >>> v14. Still suggest committing the proposed patch to master and all supported
> >>> versions to document the existing behavior correctly. The fix patch can work
> >>> from that.
>
> >> I think this is nuts. The current behavior is obviously broken;
> >> we should just treat it as a bug and fix it, including back-patching.
> >> I do not think there is a compatibility problem of any significance.
> >> Who out there is going to have an application that is relying on the
> >> ability to insert BC dates in this way?
>
> > You are agreeing with what I am suggesting then?
>
> Hm, I read your reference to "the release notes" as suggesting that
> we should change it only in a major release, ie HEAD only (and it
> looks like David read it the same). If you meant minor release notes,
> then we're on the same page.
Yes, I was thinking just the major release notes. What are you
suggesting, and what did you ultimately decide to do? What I didn't
want to do was to document the old behavior in the old docs and change
it in PG 14.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
Subject: Re: BUG #16419: wrong parsing BC year in to_date() function
In-Reply-To: <20200930184216.GE26841@momjian.us>
References: <CAKFQuwaXESne_VYt8bE8L5gGGqEM0TCGL+JNL1a8NJ2_uc8VfQ@mail.gmail.com> <CAKFQuwajC7+s-nHRujP+w5GsUTcp8usazdPas59Kz3kCTq+e3w@mail.gmail.com> <0123b852ae3fe53eca11b9451d035411b06dafd5.camel@cybertec.at> <CAKFQuwb_3yNTTE6cG_YtXFtV=CkQf0uMSMB0oxC1YNrF94pfuA@mail.gmail.com> <20200904012149.GA13932@momjian.us> <CAKFQuwZV0UxbyYTxuJhf1j1X=3HG5QA6qtEp+C+=LzOFtNEt3A@mail.gmail.com> <20200904201224.GD6891@momjian.us> <663099.1601400389@sss.pgh.pa.us> <20200930175642.GC26841@momjian.us> <888835.1601489514@sss.pgh.pa.us> <20200930184216.GE26841@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox