pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Henry Hinze <henry.hinze@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop
Date: Thu, 1 Oct 2020 21:08:54 -0300
Message-ID: <20201002000854.GA18560@alvherre.pgsql> (raw)
In-Reply-To: <e7521db4-119f-b256-f338-a35d80d50fb4@2ndquadrant.com>

On 2020-Oct-01, Peter Eisentraut wrote:

> On 2020-09-30 23:32, Tom Lane wrote:
> > The question that this raises is how the heck did that get past
> > our test suites?  It seems like the error should have been obvious
> > to even the most minimal testing.
> 
> What's the difference between this case and what the test suite is testing?
> Is it that it replicates between two databases on the same instance?

I don't know why the tests pass, but the message
  ERROR:  error reading result of streaming command: 
does appear in the logs after running src/test/subscription many times
(I see it in tests 001, 002, 013 and 014, apart from the new one in
100).  It's indeed surprising that these tests all pass!

I turned Henry's reproducer into the attached TAP test, and it does
reproduce the problem; but if I reduce the number of rows from 5000 to
1000, then it no longer does.  I don't quite see why this would be a
problem with a larger table only.  Do you?

The fix is the commented-out line in walsender.c; the test reliably
passes for me if I uncomment that, and the error message disappear from
the server logs in all the other tests.

Attachments:

  0001-Restore-double-command-completion-tags.patch (text/x-diff, 0B) download

view thread (51+ messages)  latest in thread

Message-ID: <20201002000854.GA18560@alvherre.pgsql>
Permalink:  ../20201002000854.GA18560@alvherre.pgsql/
Also on:    postgresql.org/message-id/20201002000854.GA18560@alvherre.pgsql

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, henry.hinze@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16643: PG13 - Logical replication - initial startup never finishes and gets stuck in startup loop
  In-Reply-To: <20201002000854.GA18560@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox