From: Bruce Momjian <bruce@momjian.us>
To: neverov.max@gmail.com
To: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
Date: Tue, 23 Mar 2021 12:03:36 -0400
Message-ID: <20210323160336.GE579@momjian.us> (raw)
In-Reply-To: <16939-cceeb03fb72736ee@postgresql.org>
References: <16939-cceeb03fb72736ee@postgresql.org>
On Tue, Mar 23, 2021 at 05:21:30AM +0000, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 16939
> Logged by: Max Neverov
> Email address: neverov.max@gmail.com
> PostgreSQL version: 13.2
> Operating system: alpine
> Description:
>
> Execute the query:
> postgres=# set intervalstyle='postgres';
> SET
> postgres=# select interval '-1 year -1 day';
> interval
> ------------------
> -1 years -1 days
> (1 row)
>
> Expected output:
> -1 year -1 day
>
> The code
> (https://github.com/postgres/postgres/blob/master/src/backend/utils/adt/datetime.c#L4193)
> pluralizes a time unit if the value is not 1, should check both -1 and 1.
>
Wow, interesting. Seems there were a few places in the code that
handled this properly, and several that didn't. The attached patch
fixes these and updates the regression tests. I will apply this for PG
14 in the next few days. This is too likely to break something to
backpatch. Thanks for the report.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
plural.diff (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-Reply-To: <20210323160336.GE579@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox