From: Bruce Momjian <bruce@momjian.us>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: neverov.max@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
Date: Sat, 1 May 2021 10:55:41 -0400
Message-ID: <20210501145541.GC23068@momjian.us> (raw)
In-Reply-To: <20210430010004.GA23068@momjian.us>
References: <20210425115726.GA2353095@rfd.leadboat.com>
<20210426163116.GR7629@momjian.us>
<2266336.1619455534@sss.pgh.pa.us>
<20210426165435.GT7629@momjian.us>
<2267469.1619456564@sss.pgh.pa.us>
<20210426170616.GV7629@momjian.us>
<20210427061329.GB2435607@rfd.leadboat.com>
<20210427201019.GY7629@momjian.us>
<20210428054415.GA2493304@rfd.leadboat.com>
<20210430010004.GA23068@momjian.us>
On Thu, Apr 29, 2021 at 09:00:04PM -0400, Bruce Momjian wrote:
> OK, first, I never realized that saying -1 plural was valid. Second,
> the two places you showed are actually using abs() properly since
> negative values are shown with an "ago" suffix, not a negative sign:
>
> SET intervalstyle = postgres_verbose;
>
> SELECT '2020-01-01 01:03:00'::timestamptz - '2020-01-01 02:02:01'::timestamptz;
> ?column?
> ---------------------
> @ 59 mins 1 sec ago
> (1 row)
>
> Attached is a patch which reverts 9ee7d533da and 5da9868ed9, and adds a
> comment about the "ago" usage. The good news is that we were already
> consistent in using plural -1. :-)
Here is a clearer example:
SET intervalstyle = postgres_verbose;
SELECT '2020-01-01 00:00:01'::timestamptz - '2020-01-01 00:00:00'::timestamptz;
?column?
----------
@ 1 sec
SELECT '2020-01-01 00:00:00'::timestamptz - '2020-01-01 00:00:01'::timestamptz;
?column?
-------------
@ 1 sec ago
Patch applied. Thanks for the research.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: bruce@momjian.us, noah@leadboat.com, tgl@sss.pgh.pa.us, neverov.max@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16939: Plural interval for negative singular
In-Reply-To: <20210501145541.GC23068@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox