From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Jeremy Schneider <schnjere@amazon.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
Date: Fri, 4 Jun 2021 19:35:33 -0400
Message-ID: <202106042335.o64q6dui5hu2@alvherre.pgsql> (raw)
In-Reply-To: <c41e5883-aedf-7944-010e-0b48b6c677ba@amazon.com>
On 2021-Jun-04, Jeremy Schneider wrote:
> ERROR: XX000: could not open relation with OID 0
> LOCATION: ReorderBufferToastReplace, reorderbuffer.c:305
Hah.
It seems to me that this code should silently return if
rd_rel->reltoastrelid == 0; just like in the case of
txn->toast_hash == NULL. It evidently means that no datum can be
toasted, and therefor no toast replacement is needed.
(As far as I recall, a table cannot go from having a toast table to not
having one.)
--
Álvaro Herrera Valdivia, Chile
"¿Qué importan los años? Lo que realmente importa es comprobar que
a fin de cuentas la mejor edad de la vida es estar vivo" (Mafalda)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, schnjere@amazon.com, andres@anarazel.de, bdrouvot@amazon.com, tomas.vondra@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: logical decoding bug: segfault in ReorderBufferToastReplace()
In-Reply-To: <202106042335.o64q6dui5hu2@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox