pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: jeff.janes@gmail.com
Cc: mk@071.ovh
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
Date: Thu, 15 Jul 2021 17:33:20 -0400
Message-ID: <202107152133.dekh4keh4r44@alvherre.pgsql> (raw)
In-Reply-To: <202107152049.3kftantyynji@alvherre.pgsql>

On 2021-Jul-15, Alvaro Herrera wrote:

> Actually, looking again, isn't this supposed to happen in KeepLogSeg()?
> We have a block that caps to max_slot_wal_keep_size_mb there ... why did
> that not work?

I find that this smaller patch is sufficient to make the added test case
work.  However, I'm not sure I understand *why* ...

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/

Attachments:

  v5-0001-Advance-old-segment-horizon-properly-after-slot-i.patch (text/x-diff, 0B) download

view thread (27+ messages)  latest in thread

Message-ID: <202107152133.dekh4keh4r44@alvherre.pgsql>
Permalink:  ../202107152133.dekh4keh4r44@alvherre.pgsql/
Also on:    postgresql.org/message-id/202107152133.dekh4keh4r44@alvherre.pgsql

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, horikyota.ntt@gmail.com, jeff.janes@gmail.com, mk@071.ovh, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17103: WAL segments are not removed after exceeding max_slot_wal_keep_size
  In-Reply-To: <202107152133.dekh4keh4r44@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox