pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Date: Mon, 23 Aug 2021 22:37:53 -0700
Message-ID: <20210824053753.GA1887090@rfd.leadboat.com> (raw)
In-Reply-To: <FF50049D-AA61-4C86-9339-841102E7CE97@yandex-team.ru>
References: <20210807221957.GA169359@rfd.leadboat.com>
	<5E041A70-4946-489C-9B6D-764DF627A92D@yandex-team.ru>
	<20210808163752.GB23176@rfd.leadboat.com>
	<20210814221328.GA146778@rfd.leadboat.com>
	<20210815084535.GA1227376@rfd.leadboat.com>
	<E86CBC3F-1FCF-44BF-BAD8-1301F66D8767@yandex-team.ru>
	<20210816051317.GA1409586@rfd.leadboat.com>
	<4A911574-5F35-4AED-BD88-8214C081CF71@yandex-team.ru>
	<5F423E04-BDAE-42AC-9CEF-1E37F6F345DF@yandex-team.ru>
	<FF50049D-AA61-4C86-9339-841102E7CE97@yandex-team.ru>

On Mon, Aug 23, 2021 at 10:38:00PM +0500, Andrey Borodin wrote:
> > 22 авг. 2021 г., в 22:42, Andrey Borodin <x4mmm@yandex-team.ru> написал(а):
> > Currently when testing combination of all fixes I observe things like
> > 'error running SQL: 'psql:<stdin>:1: ERROR:  prepared transaction with identifier "a" is busy''
> > Looks like kind of race condition in tests.
> 
> There was a race condition in deterministic 2PC test. Fixed with synchronisation points.
> PFA patches that work on my machines.
> I'm going to start fixing review notes if it will not break until tomorrow.

That is great news.

> BTW are subtransaction anything special wrt CIC? is it worth to sprinkle some SAVEPOINTs here and there, just to be sure?

Not especially.  The AssignTransactionId() "Ensure parent(s) have XIDs"
behavior may be important to CIC.  In the test pgbench runs for scripts
002_pgbench_concurrent_2pc and 002_pgbench_concurrent_transaction, it likely
wouldn't hurt to pass two equal-weight test scripts, one of which uses
savepoints.





view thread (107+ messages)  latest in thread

Message-ID: <20210824053753.GA1887090@rfd.leadboat.com>
Permalink:  ../20210824053753.GA1887090@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20210824053753.GA1887090@rfd.leadboat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: noah@leadboat.com, x4mmm@yandex-team.ru, pgsql-bugs@lists.postgresql.org, michael@paquier.xyz, tgl@sss.pgh.pa.us, pg@bowt.ie
  Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
  In-Reply-To: <20210824053753.GA1887090@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox