pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: krking@zju.edu.cn
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17477: A crash bug in transformValuesClause()
Date: Mon, 9 May 2022 22:55:06 +0200
Message-ID: <202205092055.n227skur4e3a@alvherre.pgsql> (raw)
In-Reply-To: <3809468.1652109938@sss.pgh.pa.us>

Looking at the code, I understand that what your patch is doing is
making the zeroth case no longer a special one but rather handled it in
the same loop block as the other cases, which is why the bug is fixed.
LGTM.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Ed is the standard text editor."
      http://groups.google.com/group/alt.religion.emacs/msg/8d94ddab6a9b0ad3





view thread (9+ messages)  latest in thread

Message-ID: <202205092055.n227skur4e3a@alvherre.pgsql>
Permalink:  ../202205092055.n227skur4e3a@alvherre.pgsql/
Also on:    postgresql.org/message-id/202205092055.n227skur4e3a@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, sawada.mshk@gmail.com, krking@zju.edu.cn, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17477: A crash bug in transformValuesClause()
  In-Reply-To: <202205092055.n227skur4e3a@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox