pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: 王海洋 <wanghaiyang.001@bytedance.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [External] Re: [PATCH] BUG FIX: inconsistent page found in BRIN_REGULAR_PAGE
Date: Fri, 5 Aug 2022 15:17:31 +0200
Message-ID: <20220805131731.jhtscj2tonbglxz6@alvherre.pgsql> (raw)
In-Reply-To: <CACciXACqJBkVAhj5pobKfgqGnYmqRu13YntFuuO8hZNLxYV=Yw@mail.gmail.com>

On 2022-Aug-04, 王海洋 wrote:

> Thanks, I agree. So my new modified patch is attached.

I propose the attached.  This also adds a new TAP test that runs BRIN
through a revmap extension and through wal_consistency_checking.  This
increases coverage, as currently there's none for brin_evacuate_page.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Every machine is a smoke machine if you operate it wrong enough."
https://twitter.com/libseybieda/status/1541673325781196801

Attachments:

  v3-0001-add-test.patch (text/x-diff, 0B) download

view thread (10+ messages)  latest in thread

Message-ID: <20220805131731.jhtscj2tonbglxz6@alvherre.pgsql>
Permalink:  ../20220805131731.jhtscj2tonbglxz6@alvherre.pgsql/
Also on:    postgresql.org/message-id/20220805131731.jhtscj2tonbglxz6@alvherre.pgsql

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, wanghaiyang.001@bytedance.com, horikyota.ntt@gmail.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: [External] Re: [PATCH] BUG FIX: inconsistent page found in BRIN_REGULAR_PAGE
  In-Reply-To: <20220805131731.jhtscj2tonbglxz6@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox