From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: justin@tonic.ai
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17753: pg_dump --if-exists bug
Date: Sat, 21 Jan 2023 08:00:12 -0800
Message-ID: <20230121160012.GC1356297@rfd.leadboat.com> (raw)
In-Reply-To: <294749.1674173390@sss.pgh.pa.us>
References: <17753-9c8773631747ee1c@postgresql.org>
<CAApHDvq+JTtZWOrXBrY7LvquyXHoCWWq=DfPYKB4b7BuFiM_8A@mail.gmail.com>
<4062761.1674142680@sss.pgh.pa.us>
<282372.1674166935@sss.pgh.pa.us>
<294749.1674173390@sss.pgh.pa.us>
On Thu, Jan 19, 2023 at 07:09:50PM -0500, Tom Lane wrote:
> I wrote:
> > I think we need to do the attached, more or less. Also, although the
> > given case seems to be new, we'd probably better back-patch, because
> > I'm not convinced that there aren't other ways to reach this.
>
> Ah --- we only need to back-patch to v15, because this business of
> possibly having a comment in the dropStmt is new in a7a7be1f2.
> That commit also added the existing exceptions for comments in
> pg_backup_archiver.c ... but it missed the need to have special
> cases for dropStmts too.
Your commit 74739d1 looks good. Thanks.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, dgrowleyml@gmail.com, justin@tonic.ai, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17753: pg_dump --if-exists bug
In-Reply-To: <20230121160012.GC1356297@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox