pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: ahodgson@simkin.ca
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17817: DISABLE TRIGGER ALL on a partitioned table with foreign key fails
Date: Fri, 3 Mar 2023 19:17:35 +0100
Message-ID: <20230303181735.quhcvh2igowmxbs7@alvherre.pgsql> (raw)
In-Reply-To: <2473213.1677858640@sss.pgh.pa.us>

On 2023-Mar-03, Tom Lane wrote:

> I wrote:
> > I can throw together a patch for what I was thinking of.
> 
> Basically just make the recursive steps match on tgparentid instead
> of name, like this.

Thank you, looks sane to me.

> I wonder whether anyplace else is making a similar mistake?  Although
> there's not much we will let you do to a foreign key trigger, so it
> might not matter for anything else.

Right ... triggers created in the normal way would have matching names,
so the previous code would work correctly.

I wonder how come this problem took so long to be detected with Ruby on
Rails; it's been in released 13.x and 14.x for seven months now.  I
suppose it would be very useful if the Ruby on Rails community would run
their tests more often on new Postgres versions (or even on the tip of
stable branches).

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.





view thread (8+ messages)  latest in thread

Message-ID: <20230303181735.quhcvh2igowmxbs7@alvherre.pgsql>
Permalink:  ../20230303181735.quhcvh2igowmxbs7@alvherre.pgsql/
Also on:    postgresql.org/message-id/20230303181735.quhcvh2igowmxbs7@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, ahodgson@simkin.ca, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17817: DISABLE TRIGGER ALL on a partitioned table with foreign key fails
  In-Reply-To: <20230303181735.quhcvh2igowmxbs7@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox