pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Richard Veselý <richard.vesely@softea.sk>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Fwd: BUG #18016: REINDEX TABLE failure
Date: Thu, 27 Jul 2023 16:10:59 -0700
Message-ID: <20230727231059.GA3612597@nathanxps13> (raw)
In-Reply-To: <CABwTF4VLS44Ypm90NsiGcyRbtdfioudUKcRUivXuQ8x1jPECPw@mail.gmail.com>
References: <18016-2bd9b549b1fe49b3@postgresql.org>
	<ZKirERBzkM48E0op@paquier.xyz>
	<1457241.1688775601@sss.pgh.pa.us>
	<CABwTF4XCTA=guV=4v3xkQnKhtqKsW2njeKeZCNtDhSFoYRWfDQ@mail.gmail.com>
	<ZKpn+44jciv6Ym3/@paquier.xyz>
	<1867443.1688912310@sss.pgh.pa.us>
	<CABwTF4WX=m5pQvKXvLFJoEH=hSd6O=iZSqxVqHKjFm+iL-AO=w@mail.gmail.com>
	<20230726175000.GA3259285@nathanxps13>
	<CABwTF4U+t-8sD2y2xhgHyj=ovPMbrsNJO5F49nvZZtpwFkwWDA@mail.gmail.com>
	<CABwTF4VLS44Ypm90NsiGcyRbtdfioudUKcRUivXuQ8x1jPECPw@mail.gmail.com>

On Wed, Jul 26, 2023 at 06:42:14PM -0700, Gurjeet Singh wrote:
> On Wed, Jul 26, 2023 at 10:50 AM Nathan Bossart
> <nathandbossart@gmail.com> wrote:
>> On Mon, Jul 10, 2023 at 09:35:05AM -0700, Gurjeet Singh wrote:
>> > The code block movement involved slightly more thought and care than I
>> > had previously imagined. As explained in comments in the patch, the
>> > enumeration and suppression of indexes on the main table must happen
>> > before any CommandCounterIncrement() call, hence the
>> > reindex-the-toast-table-if-any code had to be placed after that
>> > enumeration.
>>
>> Do we need to add another CCI after reindexing the TOAST table?  It looks
>> like we presently do so between reindexing each relation, including the
>> TOAST table.
> 
> Yes, we do need to do a CCI after reindex the relation's toast table.
> But note that it is done by the recursive call to reindex_relation(),
> right after it calls reindex_index().

*facepalm*

Ah, I see it now.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (21+ messages)  latest in thread

Message-ID: <20230727231059.GA3612597@nathanxps13>
Permalink:  ../20230727231059.GA3612597@nathanxps13/
Also on:    postgresql.org/message-id/20230727231059.GA3612597@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: nathandbossart@gmail.com, gurjeet@singh.im, tgl@sss.pgh.pa.us, michael@paquier.xyz, richard.vesely@softea.sk, pgsql-bugs@lists.postgresql.org
  Subject: Re: Fwd: BUG #18016: REINDEX TABLE failure
  In-Reply-To: <20230727231059.GA3612597@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox