From: Vojtěch Beneš <vojtech.benes@centrum.cz>
To: dgrowleyml@gmail.com
To: tgl@sss.pgh.pa.us
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18264: Table has type text, but query expects integer.attribute 1 of type record has wrong type
Date: Fri, 05 Jan 2024 18:39:32 +0100
Message-ID: <20240105183932.2D7B2BB4@centrum.cz> (raw)
I am impressed with how quickly you addressed the issue. I tested queries myself on latest builds and issue is resolved. Also all errors we were getting in more complex queries are gone.
Thank you for your work.
Vojtěch
______________________________________________________________
> Od: "David Rowley" <dgrowleyml@gmail.com>
> Komu: "Tom Lane" <tgl@sss.pgh.pa.us>
> Datum: 04.01.2024 08:43
> Předmět: Re: BUG #18264: Table has type text, but query expects integer.attribute 1 of type record has wrong type
>
> CC: <pgsql-bugs@lists.postgresql.org>
On Sun, 31 Dec 2023 at 16:24, David Rowley <dgrowleyml@gmail.com> wrote:
> It looks like the problem is in ExecEvalPreOrderedDistinctMulti(). It
> overwrites the tmpcontext's slots but fails to properly restore the
> originals again.
I pushed a slightly revised version of this. I ended up adding a bool
isdistinct local variable so I didn't have to reset the slots in two
places. It kinda makes it easier to see what the true and false
means, so that might have been a good change regardless of the bug.
Thanks for reporting this Vojtěch and for the reproducer script.
David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: vojtech.benes@centrum.cz, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18264: Table has type text, but query expects integer.attribute 1 of type record has wrong type
In-Reply-To: <20240105183932.2D7B2BB4@centrum.cz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox