From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae
Date: Mon, 15 Apr 2024 20:58:25 -0700
Message-ID: <20240416035825.8e.nmisch@google.com> (raw)
In-Reply-To: <20240415211020.vyv4oit6bpzldb6y@awork3.anarazel.de>
References: <CAEze2WjMTh4KS0=QEQB-Jq+tDLPR+0+zVBMfVwSPK5A=WZa95Q@mail.gmail.com>
<CA+TgmoafLryvjQb-sP743EaR3K3x5yZ-N2htMFQ1JFVMJyUwHQ@mail.gmail.com>
<CAAKRu_ZiE6AXAgzGhyCYVTCS0bn-g=zDhC2QHfFLGcQmdyxRLQ@mail.gmail.com>
<CA+TgmoZk19atnje-pCoj2CVuPS5FnGZdVsbqJ0vNZOvcXhYmqA@mail.gmail.com>
<CA+Tgmob1BtWcP6R5-toVHB5wqHasPTSR2TJkcDCutMzaUYBaHQ@mail.gmail.com>
<CAAKRu_aq0oZS88NxN9gEW9Ff-HK6AegTZ0FdC8C4fOZdXbwx+A@mail.gmail.com>
<CA+TgmoYUnV-RYzn00jF2irua29mdb0vqgH-LjPHiSJZG_tUQVg@mail.gmail.com>
<CA+Tgmobh6b+8Kg2P0J__ML5KDh8bJwNYZvWED_oPB=MnBaqoWQ@mail.gmail.com>
<20240415205204.57.nmisch@google.com>
<20240415211020.vyv4oit6bpzldb6y@awork3.anarazel.de>
On Mon, Apr 15, 2024 at 02:10:20PM -0700, Andres Freund wrote:
> On 2024-04-15 13:52:04 -0700, Noah Misch wrote:
> > On Mon, Apr 15, 2024 at 12:35:59PM -0400, Robert Haas wrote:
> > > I propose to remove this open item from
> > > https://wiki.postgresql.org/wiki/PostgreSQL_17_Open_Items
> > >
> > > On the original thread (BUG #17257), Alexander Lakhin says that he
> > > can't reproduce this after dad1539ae/18b87b201. Based on my analysis
> >
> > I have observed the infinite loop in production with v15.5, so that
> > non-reproduce outcome is a limitation in the test procedure. (v14.2 added
> > those two commits.)
>
> How closely have you analyzed those production occurences? It's not too hard
> to imagine some form of corruption that leads to such a loop, but which isn't
> related to the horizon going backwards? E.g. a corrupted HOT chain can lead
> to heap_page_prune() not acting on a DEAD tuple, but lazy_scan_prune() would
> then encounter a DEAD tuple.
One occurrence had these facts:
HeapTupleHeaderGetXmin = 95271613
HeapTupleHeaderGetUpdateXid = 95280147
vacrel->OldestXmin = 95317451
vacrel->vistest->definitely_needed = 95318928
vacrel->vistest->maybe_needed = 93624425
How compatible are those with the corruption vectors you have in view?
> > > of the code, I suspect that there is a residual bug, or at least that
> > > there was one prior to 6f47f6883151366c031cd6fd4011e66d2c702a90.
> >
> > Can you say more about how 6f47f6883151366c031cd6fd4011e66d2c702a90 mitigated
> > the regression that 1ccc1e05ae introduced? Thanks for discovering that.
>
> Which regression has 1ccc1e05ae actually introduced? As I pointed out
> upthread, the proposed path to corruption doesn't seem to actually lead to
> corruption, "just" an error? Which actually seems considerably better than an
> endless retry loop that cannot be cancelled.
A transient, spurious error is far better than an uninterruptible infinite
loop with a buffer content lock held. If a transient error is the consistent
outcome, I would agree 1ccc1e05ae improved the situation and didn't regress
it. That would close the open item. I tried briefly to understand
https://postgr.es/m/flat/20240415173913.4zyyrwaftujxthf2@awork3.anarazel.de
but I felt verifying its argument was going to be a big job for me. Would
those errors happen transiently, like the infinite loop, or would they persist
until something resets the tuple fields (e.g. ATRewriteTables())?
Thanks,
nm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: noah@leadboat.com, andres@anarazel.de, robertmhaas@gmail.com, melanieplageman@gmail.com, boekewurm+postgres@gmail.com, pg@bowt.ie, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: relfrozenxid may disagree with row XIDs after 1ccc1e05ae
In-Reply-To: <20240416035825.8e.nmisch@google.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox