From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: matthias.hoermann@saltation.com
To: pgsql-www@lists.postgresql.org
Subject: Re: BUG #18476: Debian Install Docs have confusing code block structure
Date: Fri, 24 May 2024 12:20:05 +0200
Message-ID: <202405241020.updiuccxlbl2@alvherre.pgsql> (raw)
In-Reply-To: <18476-5cf162189c5c6dbc@postgresql.org>
Moved thread to pgsql-www.
On 2024-May-23, PG Bug reporting form wrote:
> On https://www.postgresql.org/download/linux/debian/ the commands to
> manually install the repository and the commands to install packages from
> the repository are in one big code block and the text before it suggests
> that this code block is optional if you use the script above it. However the
> script (without parameters at least) only installs the repository, not the
> packages from the repository. Maybe two code blocks were accidentally merged
> here and the text in between deleted?
I agree, it doesn't look good to have a button for "copy script" that
includes a line that installs a package after having enabled the repo.
Much less one that does so without asking for confirmation! That line
should be separate.
I think the attached patch achieves that, but
1) it's untested
2) I'm not sure that a "Copy Script" button is really all that useful
for the "apt install" line, so maybe that part of this patch should be
scrapped.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"People get annoyed when you try to debug them." (Larry Wall)
Attachments:
0001-Split-the-install-script-in-download-linux-debian.patch (text/x-diff, 0B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@alvh.no-ip.org, matthias.hoermann@saltation.com, pgsql-www@lists.postgresql.org
Subject: Re: BUG #18476: Debian Install Docs have confusing code block structure
In-Reply-To: <202405241020.updiuccxlbl2@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox