agora inbox for pgsql-bugs@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Japin Li <japinli@hotmail.com>
Cc: Keith Paskett <keith.paskett@logansw.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: pg_restore error with partitioned table having exclude constraint
Date: Wed, 30 Apr 2025 12:45:11 +0200
Message-ID: <202504301045.7cjojr7ut2fo@alvherre.pgsql> (raw)
In-Reply-To: <ME0P300MB0445A5BF45A46CC72B39C580B6832@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM>
On 2025-Apr-30, Japin Li wrote:
> Thank you for the explanation. A test case has been added to create_index.sql.
> Could you please take a look?
Well, it seems a bit minimalistic -- I would try to be more adversarial
about it maybe, because details are where devil(s) lie.
You need to add comments in CompareIndexInfo about your new code. Why
is it okay to ignore ii_ExclusionProcs and ii_ExclusionStrats? Why is
it okay to not have tests that set up tables with those things as
different so that this function returns false in these cases? Why do
you have a test for a table set up where the positive case is handled,
but no case for the negative case?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
view thread (15+ messages) latest in thread
Message-ID: <202504301045.7cjojr7ut2fo@alvherre.pgsql>
Permalink: ../202504301045.7cjojr7ut2fo@alvherre.pgsql/
Also on: postgresql.org/message-id/202504301045.7cjojr7ut2fo@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@kurilemu.de, japinli@hotmail.com, keith.paskett@logansw.com, pgsql-bugs@lists.postgresql.org
Subject: Re: pg_restore error with partitioned table having exclude constraint
In-Reply-To: <202504301045.7cjojr7ut2fo@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox