From: Álvaro Herrera <alvherre@kurilemu.de>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: andrewbille@gmail.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases
Date: Sat, 18 Oct 2025 18:22:16 +0200
Message-ID: <202510181619.crppv2bdx2xm@alvherre.pgsql> (raw)
In-Reply-To: <CAFiTN-sfxzgd1ntJx=GPjsbvEkA-0YeaLsKdzMm=X5aUSDqL9g@mail.gmail.com>
On 2025-Oct-06, Dilip Kumar wrote:
> I think we can fix it in getTableAttrs(), see attached, with that I
> can see my dump is correct. This is just a quick way to show what I
> am thinking, maybe we can improve this condition.
Pushed, thanks. I added a test so that cross-version upgrade will hit
this. Because this code is not used except when upgrading from 17 or
older, I had to modify 17 even though that version needs no code changes
itself. (I verified that the pg_upgrade test fails if I have this table
in a pg_dumpall from version 17 -- and the diff is exactly this missing
NOT NULL constraint.)
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: alvherre@kurilemu.de, dilipbalaut@gmail.com, dgrowleyml@gmail.com, andrewbille@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19074: pg_dump from v18 loses the NOT NULL flag in the inherited table field when dumping v17-databases
In-Reply-To: <202510181619.crppv2bdx2xm@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox