agora inbox for pgsql-bugs@postgresql.org  

help / color / mirror / Atom feed

From: Andrey Chernyy <andrey.cherny@tantorlabs.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: [PATCH] contrib/xml2: backend crash in xpath_nodeset() on the namespace axis
Date: Fri, 12 Jun 2026 01:59:06 +0300
Message-ID: <20260612015906.38b47d04@andrnote> (raw)
In-Reply-To: <aioT7ui_ZJ9RMlfM@paquier.xyz>
References: <20260611031436.5afde3cb@andrnote>
	<aioT7ui_ZJ9RMlfM@paquier.xyz>

On Thu, 11 Jun 2026 10:48:30 +0900
Michael Paquier <michael@paquier.xyz> wrote:

> What do you think?  That also deserves a backpatch to me, even if it
> is less worse than the xml2 crash you have reported.
> 
> I have grouped this fix with your patch in the attached.  Both still
> need some tests.  Each fix deserves its own commit, that's just a
> quick FYI version.

Thanks Michael, and thanks for adding the tests and back-patching! The
grouped patch looks good to me - applying the same XML_NAMESPACE_DECL
fallback to xmlXPathCastNodeToString() in core xml.c makes sense too. I
had a regression test in progress, but glad it's already covered.

--
Andrey Chernyy

view thread (4+ messages)  latest in thread

Message-ID: <20260612015906.38b47d04@andrnote>
Permalink:  ../20260612015906.38b47d04@andrnote/
Also on:    postgresql.org/message-id/20260612015906.38b47d04@andrnote

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: andrey.cherny@tantorlabs.com, michael@paquier.xyz, pgsql-bugs@lists.postgresql.org
  Subject: Re: [PATCH] contrib/xml2: backend crash in xpath_nodeset() on the namespace axis
  In-Reply-To: <20260612015906.38b47d04@andrnote>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox