pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Meskes <meskes@postgresql.org>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: jallen@americansavingslife.com
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT
Date: Sat, 24 Feb 2018 15:12:10 -0500
Message-ID: <20439.1519503130@sss.pgh.pa.us> (raw)
In-Reply-To: <20053.1519502594@sss.pgh.pa.us>
References: <151935568942.1461.14623890240535309745@wrigleys.postgresql.org>
	<1519483386.2654.291.camel@postgresql.org>
	<877er2nr8c.fsf@news-spur.riddles.org.uk>
	<1519501766.2510.13.camel@postgresql.org>
	<20053.1519502594@sss.pgh.pa.us>

I wrote:
> Michael Meskes <meskes@postgresql.org> writes:
>> Right, but it is missing in pg_config.h, too, right?

> No, it does get defined on Unix builds (if appropriate), both in
> pg_config.h and ecpg_config.h.

Oh, wait, now I see what you meant: there is no stanza like

#if (_MSC_VER > 1200)
#define HAVE_LONG_LONG_INT 1
#endif

in pg_config.h.win32.  I agree that there should be.  As I said, none
of the core backend cares at the moment ... but someday, that discrepancy
is going to bite us.

			regards, tom lane




view thread (11+ messages)  latest in thread

Message-ID: <20439.1519503130@sss.pgh.pa.us>
Permalink:  ../20439.1519503130@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20439.1519503130@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, meskes@postgresql.org, andrew@tao11.riddles.org.uk, jallen@americansavingslife.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT
  In-Reply-To: <20439.1519503130@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox