pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Jeevan Chalke <jeevan.chalke@enterprisedb.com>
Cc: sean.johnston@edgeintelligence.com, Postgres-Bugs <pgsql-bugs@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW
Date: Fri, 12 Jan 2018 16:55:17 -0500
Message-ID: <20775.1515794117@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFjFpRc-QF+wHLJrsK2PeoKWXSG+u59qtjy6G5OvBp2G0adDSg@mail.gmail.com>
References: <20171107134948.1508.94783@wrigleys.postgresql.org>
	<10660.1510093781@sss.pgh.pa.us>
	<CAM2+6=X3CwoJ6LE3AGrDmBh1-zhJVd2WAPGKk0zLqDMfhJYOhQ@mail.gmail.com>
	<CAFjFpRf6A=G-x6TL0y01iRcjjz9A7=BUa4xdwZ0fbD13RsEnMg@mail.gmail.com>
	<9632.1510339476@sss.pgh.pa.us>
	<CAM2+6=Xmpptj19Vjk1H5gBo0grZNgqvjzRd-+ahfhyOaBJwPmQ@mail.gmail.com>
	<CAFjFpRc-QF+wHLJrsK2PeoKWXSG+u59qtjy6G5OvBp2G0adDSg@mail.gmail.com>

Ashutosh Bapat <ashutosh.bapat@enterprisedb.com> writes:
> I am fine with the patch. It introduces a lot of expected output diff,
> since we always deparse GROUP BY clause in positional notation. That's
> fine. There is no point in adding extra logic to  use positional
> notation only when there are duplicate entries in the GROUP BY clause.

Yeah, agreed, particularly since that behavior has only been there since
10.0 anyway.  Pushed with a few cosmetic adjustments (mostly, improving
shaky English in the comments in foreign_grouping_ok()).

			regards, tom lane




view thread (11+ messages)

Message-ID: <20775.1515794117@sss.pgh.pa.us>
Permalink:  ../20775.1515794117@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20775.1515794117@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ashutosh.bapat@enterprisedb.com, jeevan.chalke@enterprisedb.com, robertmhaas@gmail.com
  Subject: Re: [BUGS] BUG #14890: Error grouping by same column twice using FDW
  In-Reply-To: <20775.1515794117@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox