From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Marcos David <mdavid@palantir.com>
Cc: pgsql-bugs@lists.postgresql.org <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #16106: Patch - Radius secrets always gets lowercased
Date: Tue, 12 Nov 2019 13:07:14 -0500
Message-ID: <20966.1573582034@sss.pgh.pa.us> (raw)
In-Reply-To: <CABUevEwbPJJ=5M2pTVwME5mVbH=_GrGoeg8Eo_NTj8mRMVsBEA@mail.gmail.com>
References: <16106-7d319e4295d08e70@postgresql.org>
<19993.1573503787@sss.pgh.pa.us>
<BC05948D-9509-4F30-A350-7E2C36570CF1@palantir.com>
<7942.1573576426@sss.pgh.pa.us>
<CABUevEwbPJJ=5M2pTVwME5mVbH=_GrGoeg8Eo_NTj8mRMVsBEA@mail.gmail.com>
Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Nov 12, 2019 at 10:33 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, while you can defeat the downcasing that way, you can't
>> bypass the truncation to NAMEDATALEN. So it's arguably broken
> I believe the RADIUS standard doesn't actually specify the length of the
> key, so different implementations have different limits. For example
> freeradius has 48 characters, cisco has 63.
I agree that it's somewhat unlikely that truncation at 63 bytes would
matter in practical use-cases, for any of these four parameters.
Still, it's not a good thing, and the fix is trivial given that we
have a suitable function at hand already.
I'll try to improve the docs while I'm at it.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, magnus@hagander.net, mdavid@palantir.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16106: Patch - Radius secrets always gets lowercased
In-Reply-To: <20966.1573582034@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox