pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mats Kindahl <mats@timescale.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17876: Function width_bucket() for float8 input returns value out of range
Date: Wed, 05 Apr 2023 17:41:06 -0400
Message-ID: <2173637.1680730866@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+14427tOx9GXw2Va_W0HF7Wp7kiu31BNju_=3SnCuaXOAdJzQ@mail.gmail.com>
References: <17876-61f280d1601f978d@postgresql.org>
	<CA+14427KvPsskajKSriGACyrudcOyh5ohmt=0WPuNjoMTSQM6A@mail.gmail.com>
	<3807420.1680093217@sss.pgh.pa.us>
	<CA+14424DZUcLpWnoRURmT1m6Uet1_R39sV=8XhtFRiigVtYqDg@mail.gmail.com>
	<186575.1680190503@sss.pgh.pa.us>
	<CA+14425g=sw2g+6KYCfz2x1YwYz0X2MwWeUu0U5Ba8BHkSi2jw@mail.gmail.com>
	<391415.1680268470@sss.pgh.pa.us>
	<CA+14427tOx9GXw2Va_W0HF7Wp7kiu31BNju_=3SnCuaXOAdJzQ@mail.gmail.com>

Mats Kindahl <mats@timescale.com> writes:
> On Fri, Mar 31, 2023 at 3:14 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> While I'm not bothered too much if rounding affects which internal
>> bucket a value lands in, it's a bit more annoying if that causes
>> it to be reported as being in the end bucket, when we know positively
>> that the value is less than bound2.  Is it worth expending more
>> cycles to prevent this?

> I think it could be. I agree that it does not make sense to select the end
> bucket when the value is in range, even if just.

Yeah.  I did that already at a2a0c7c29, sorry for not circling back
to this thread.

			regards, tom lane





view thread (9+ messages)

Message-ID: <2173637.1680730866@sss.pgh.pa.us>
Permalink:  ../2173637.1680730866@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2173637.1680730866@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mats@timescale.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #17876: Function width_bucket() for float8 input returns value out of range
  In-Reply-To: <2173637.1680730866@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox