pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: r.zharkov@postgrespro.ru
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16484: pg_regress fails with --outputdir parameter
Date: Tue, 09 Jun 2020 01:55:06 -0400
Message-ID: <2192706.1591682106@sss.pgh.pa.us> (raw)
In-Reply-To: <20200609053356.GC38342@paquier.xyz>
References: <16484-4d89e9cc11241996@postgresql.org>
	<153B2C23-E972-4D2B-BBD3-EA77AEB79329@yesql.se>
	<20200609053356.GC38342@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> And this leads me to the attached.

That will create the output directory even if indir doesn't exist, which
seems likely to lead to bogus directories hanging around in places where
we don't need them --- plus it seems rather ugly to drop this into the
middle of the sequence concerned with indir.  So shouldn't the new code
be after the exit for indir not existing?

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <2192706.1591682106@sss.pgh.pa.us>
Permalink:  ../2192706.1591682106@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2192706.1591682106@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, daniel@yesql.se, r.zharkov@postgrespro.ru, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #16484: pg_regress fails with --outputdir parameter
  In-Reply-To: <2192706.1591682106@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox