From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Sosinski <robert.sosinski@reactive.io>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST
Date: Wed, 02 Jun 2021 18:58:17 -0400
Message-ID: <232375.1622674697@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFkjL2WRM9wnR6vBgypnGzqW+5aTqvYiM1J12Nwg0-KZadatSQ@mail.gmail.com>
References: <17045-6a4a9f0d1513f72b@postgresql.org>
<165910.1622665167@sss.pgh.pa.us>
<CAFkjL2WRM9wnR6vBgypnGzqW+5aTqvYiM1J12Nwg0-KZadatSQ@mail.gmail.com>
Robert Sosinski <robert.sosinski@reactive.io> writes:
> I would revise my statement to say this change to PostgreSQL 14 would
> significantly break existing PostgREST applications, to the point that they
> would be unable to upgrade to 14.
Fair enough. I also dug around a bit and noted that the core grammar
explicitly allows SET/SHOW variable names to have any number of
components:
var_name: ColId { $$ = $1; }
| var_name '.' ColId
{ $$ = psprintf("%s.%s", $1, $3); }
;
That dates clear back to commit 3dc37cd8d of 2004-05-26. While it's
fair to wonder how intentional it was, given that the commit log
message only mentions "qualified name in the form <ID>.<ID>",
nonetheless people have been able to write this --- without any tricks
like double-quotes --- for a mighty long time. So I now agree that
we shouldn't forbid it. Done at
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=2955c2be79b35fa369c83fa3b5f44661c...
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: tgl@sss.pgh.pa.us, robert.sosinski@reactive.io, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17045: 14 Beta Tighten up allowed names for custom GUC parameters breaks PostgREST
In-Reply-To: <232375.1622674697@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox