pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: martin@schlossarek.me
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18057: unaccent removes intentional spaces
Date: Sat, 19 Aug 2023 12:30:04 -0400
Message-ID: <2334732.1692462604@sss.pgh.pa.us> (raw)
In-Reply-To: <ZN8NUpx2f9pB+F/g@paquier.xyz>
References: <18057-62712cad01bd202c@postgresql.org>
	<ZNwRq4nV7CBXAoJN@paquier.xyz>
	<ZN8NUpx2f9pB+F/g@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> I was looking at the code, and my first impression was right.  All
> leading and trailing whitespaces between the two characters listed in
> the rule file are discarded.  The thing is that we clearly document
> the parsing rules for the sake of any custom files one can feed to the
> extension:
> https://www.postgresql.org/docs/devel/unaccent.html

> I am not sure what we can do here.  Doing nothing is certainly an
> option, but I am wondering if we could put in place an extra rule
> where whitespaces can be part of the translated character if it uses
> double quotes, for example.  Thoughts?

Yeah, we could extend the parsing rules that way.  It would break
any rules files that currently use double quote as a plain character,
but it seems unlikely that there are any.  In any case, as long as
this wasn't back-patched I think such a change would be acceptable.

			regards, tom lane





view thread (10+ messages)  latest in thread

Message-ID: <2334732.1692462604@sss.pgh.pa.us>
Permalink:  ../2334732.1692462604@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2334732.1692462604@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, martin@schlossarek.me, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #18057: unaccent removes intentional spaces
  In-Reply-To: <2334732.1692462604@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox